allow creation of paragraph in body above/below table #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marijnh
added a commit
that referenced
this pull request
Oct 13, 2017
|
I hope patch c6824e5 address this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using
allowGapCursor = falseon nodes higher up to prevent the gap cursor to be placed in them. Also, when inserting inline nodes into blocks that are not Textblock nodes, it doesn't try to directly insert the nodes, but wraps them inside a textblocknodetype defined with.defaultTextBlock = truein the schemaThis should not be merged directly, as I was missing a lot of knowledge about other situations in which gapcursor is to be used, so I don't know if it is breaking anything for others. Also, it seems like there already is a way to determine which textblock node is the default one, or how content should be wrapped that is being used in other places. At any rate, I hope this serves to show what kinds of additions we would need for our particular usecase.