added inCode flag #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added inCode flag to inputRule specs to allow inputRules to selectively apply to code blocks.
marijnh
reviewed
Jan 29, 2024
src/inputrules.ts
Outdated
| @@ -35,12 +36,17 @@ export class InputRule { | |||
| /// When set to false, | |||
| /// [`undoInputRule`](#inputrules.undoInputRule) doesn't work on | |||
| /// this rule. | |||
| undoable?: boolean | |||
| undoable?: 'boolean', | |||
There was a problem hiding this comment.
I don't think this should be a string.
There was a problem hiding this comment.
yes, you're right, don't know how I changed that.
marijnh
reviewed
Jan 29, 2024
src/inputrules.ts
Outdated
| @@ -11,6 +11,7 @@ export class InputRule { | |||
|
|
|||
| /// @internal | |||
| undoable: boolean | |||
| inCode?: 'allowed' | 'only'; | |||
There was a problem hiding this comment.
Could you make this boolean | "only", so people can also explicitly provide false?
|
Just curious since this is my first pull request -- how long should I expect it to take to have it merged? days, weeks, months? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added inCode flag to inputRule specs to allow inputRules to selectively apply to code blocks.