Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a bounding rectangle to be set for tooltips, see #249 #258

Closed
wants to merge 1 commit into from
Closed

Allow a bounding rectangle to be set for tooltips, see #249 #258

wants to merge 1 commit into from

Conversation

kiejo
Copy link
Contributor

@kiejo kiejo commented Mar 9, 2016

Easy way to try this out is to use the following line in the TooltipMenu constructor.

this.tooltip = new Tooltip(pm.wrapper, {direction: "above", getBoundingRect: () => this.pm.wrapper.getBoundingClientRect()})

marijnh added a commit that referenced this pull request Mar 9, 2016
@marijnh
Revise 7d147e0
8c230ae 
Issue #258
@marijnh
Copy link
Member

marijnh commented Mar 9, 2016

Thanks! Merged as 7d147e0 and followed up with some cosmetic changes in 8c230ae.

@marijnh marijnh closed this Mar 9, 2016
@marijnh marijnh mentioned this pull request Mar 9, 2016
Closed
kiejo pushed a commit to kiejo/prosemirror that referenced this pull request Mar 10, 2016
@marijnh @kiejo
Revise 7d147e0
cea32af 
Issue ProseMirror#258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiejo @marijnh