Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Support WC 3.0 #96

Closed
manospsyx opened this issue Jan 20, 2017 · 9 comments · Fixed by #136
Closed

Support WC 3.0 #96

manospsyx opened this issue Jan 20, 2017 · 9 comments · Fixed by #136
Assignees
Milestone

Comments

@manospsyx
Copy link
Member

manospsyx commented Jan 20, 2017

Opening this to start working on WC 2.7 compatibility.

Since SATT does not extend any core CRUD classes, WC 2.7 compatibility is limited to the following tasks (more added as we investigate):

  • Stop accessing CRUD object properties directly.
  • Stop accessing deprecated object properties.
  • Look for deprecated CRUD object functions and use new ones where applicable.
  • Replace deprecated filters with new equivalents.
  • Phase out use of post/post meta functions.
  • Use CRUD API to save plugin data on product objects.
@manospsyx manospsyx self-assigned this Jan 20, 2017
@manospsyx manospsyx modified the milestones: 1.1.x, 1.2 Jan 20, 2017
@manospsyx
Copy link
Member Author

Switching milestone to 1.2.

Reason: Scheme data will be obtained via the Product API in 1.2, which will abstract a lot of direct get_post_meta calls. Once this is done, scheme data will be obtained using WC_Data::get_meta.

@manospsyx
Copy link
Member Author

See https://github.com/Prospress/woocommerce-subscribe-all-the-things/tree/issue-96

Leaving this open until we can test with a final WC 2.7-compatible version of WCS.

@manospsyx manospsyx changed the title Support WC 2.7 Support WC 3.0 Apr 5, 2017
@manospsyx
Copy link
Member Author

On with this :)

manospsyx pushed a commit that referenced this issue Apr 5, 2017
manospsyx pushed a commit that referenced this issue Apr 5, 2017
@manospsyx
Copy link
Member Author

Quick update:

If you depend on SATT, it is recommended to stick with WC 2.6 until a final SATT 2.0 release is available. Feel free to take the 2.0 branch for a spin and let me know what works / doesn't work under WC 3.0 / WCS 2.2 . Thanks!

See progress in master...2.0

@manospsyx
Copy link
Member Author

Note: Integrations with PB, CP and MnM do not work in 2.0 just yet, as they need to be revised to utilize the new Products API introduced in SATT 2.0

@Beboris2
Copy link

Beboris2 commented Jul 2, 2017

Hi,
I was trying to evaluate this plugin which looked pretty cool.
I checked out branch 2.0 and gave it a run alongside WC 3
As you can see from the screenshot (https://ibb.co/hsK8Cv), if I select 24 months subscription for the whole cart, it still shows the full price(s). Is it a bug or there are some extra settings I need to tweak?

@sambomcd
Copy link

sambomcd commented Jul 8, 2017

Hi,

I know you guys are super busy with the 2.0 update (huge thanks!), and I don't want to waste your time. I've been trying 2.0 out. Forgive the vagueness, but pre2.0 if I was subscribed to a Product Bundle, and the items bundled within that changed between renewals, then the next renewal would give me the updated contents of the Bundle. I am seeing in 2.0 that if I change the items in the Bundle, each renewal just keeps giving me the same contents as when i first signed up, even if those products have since been removed from the Bundle.

May be a unique user case, and I know that PB's are not quite supported in 2.0 yet, but I thought it worth asking, otherwise I am headed in the wrong direction bigly.

@manospsyx
Copy link
Member Author

@sambomcd Can you please open a new issue about this? Thanks!

@sambomcd
Copy link

sambomcd commented Jul 8, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants