Zmiana bazowego adresu url dla środowisk development i staging, dodan… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axadiw
previously approved these changes
Apr 3, 2020
|
|
||
| public static var registrationDebugNoSms: Tweak<Bool> = { | ||
| let description = DebugItemDescription(.registration, group: .oneTimeCode, name: "Rejestracja dev bez SMSa") | ||
| return Tweak<Bool>.build(with: description, default: false) |
There was a problem hiding this comment.
moze tutaj moznaby zrobic sprawdzanie srodowiska i na devie dawac default value = true?
| tweak.addClosure { | ||
| //swiftlint:disable force_unwrapping | ||
| let sandboxId = Identifier(nonEmpty: Constants.ValetSandboxIds.secrets)! | ||
| let valet = Valet.valet(with: sandboxId, accessibility: .afterFirstUnlock) |
There was a problem hiding this comment.
jakbys chcial usunac tego force unwrapa stąd to mozesz podobnie jak w actionShowEncountersDebugScreen odwolac sie do resolvera z appdelegate i nim stworzyc RegistrationManager
Axadiw
previously approved these changes
Apr 3, 2020
…o RegistrationManager, dodano logikę pokazywania sekcji do głównego kontrolera widoku, dodano opcje menu deweloperskiego dla rejestracji i onboardingu
jerzyKleszcz
force-pushed
the
onboarding_menu_debugowe
branch
from
e3d47a6
to
39edcca
Compare
Axadiw
approved these changes
Apr 3, 2020
This was referenced Apr 3, 2020
qLb
pushed a commit
that referenced
this pull request
May 28, 2020
qLb
pushed a commit
that referenced
this pull request
May 28, 2020
!!Review Onboarding (#40) PR first!!! Passing app lifecycle to PWA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o RegistrationManager, dodano logikę pokazywania sekcji do głównego kontrolera widoku, dodano opcje menu deweloperskiego dla rejestracji i onboardingu