Update ProtoDef submodule #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing because ProtoDef-io/ProtoDef@4e2d2d1...674aa47#diff-74b870a7a0657a0b5e81baa41994a5ce593ecb87b6831bd26f3f5e84426c896c Seems the change to strings, specifically |
|
The error seems to be about numeric? |
|
Yeah, the error does say something about varints but I don't think that's the cause of it. Undoing the change in nickelpro's commit fixes the test, so after some debugging it seems cstring schema declaration is what's causing it to break |
rom1504
pushed a commit
to ProtoDef-io/ProtoDef
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.