This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
Add "Exclude" attribute support to Compile tag #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the following documents: https://docs.microsoft.com/en-us/visualstudio/msbuild/how-to-exclude-files-from-the-build https://docs.microsoft.com/en-us/dotnet/core/tools/csproj The Compile & Content tags did support glob patterns, and "exclude" is an essential complement to "include". This is very useful for porting existing Unity modules / plugins to Protobuild (for example exclude those files inside the Editor folder while using globs).
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
Thanks for this, I'm testing these changes now. |
|
Nice, thank you very much for your fast responds and hopes this feature will soon appear in stable releases. |
|
Just waiting on the tests to pass on the build server, then I'll squash and merge this change in. |
|
Don't worry about that build failure - that's me manually restarting the macOS build. |
|
I'm going to go ahead and merge this, as the macOS agent build is stalling on the new build server and I'm not quite sure of the cause yet (though confident it's not this change). Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the following documents:
https://docs.microsoft.com/en-us/visualstudio/msbuild/how-to-exclude-files-from-the-build
https://docs.microsoft.com/en-us/dotnet/core/tools/csproj
The Compile & Content tags did support glob patterns, and "exclude" is an essential complement to "include".
This is very useful for porting existing Unity modules / plugins to Protobuild (for example exclude those files inside the Editor folder while using globs).