fix(GODT-2587): Fix infinite loop in RFC5322 Domain Specifier

ProtonMail · Apr 25, 2023 · 8ec759b · 8ec759b
1 parent dfde413
commit 8ec759b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/rfc5322/address.go b/rfc5322/address.go
@@ -531,7 +531,8 @@ func isDText(tokenType rfcparser.TokenType) bool {
 	if rfcparser.IsCTL(tokenType) ||
 		tokenType == rfcparser.TokenTypeLBracket ||
 		tokenType == rfcparser.TokenTypeRBracket ||
-		tokenType == rfcparser.TokenTypeBackslash {
+		tokenType == rfcparser.TokenTypeBackslash ||
+		tokenType == rfcparser.TokenTypeEOF {
 		return false
 	}
 

diff --git a/rfc5322/parser_test.go b/rfc5322/parser_test.go
@@ -852,3 +852,8 @@ func TestParserAddressEmailValidation(t *testing.T) {
 		})
 	}
 }
+
+func TestParse_GODT_2587_infinite_loop(t *testing.T) {
+	_, err := ParseAddressList("00@[000000000000000")
+	assert.Error(t, err)
+}