-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for parsing TrustSignature packets #138
Add support for parsing TrustSignature packets #138
Conversation
Hey 👋 Thanks for the PR, and apologies for the delay! (I was on vacation last week.) I have a small nitpick about the API: I think the And then, to simplify things more, I would tend to add two properties, |
@twiss updated with your feedback! |
Thanks! Is there some reason If you want to check that the |
I agree with the argument it is nonsensical, but it sounds like from the RFC that 0 is an allowed value:
However, I can make it not-a-pointer, and just assume if level > 0, then Amount was intentionally set to 0 (as is allowed by the RFC). |
@twiss updated |
Right. The downside of this is that someone might forget to set the |
This is written to address: #86
This change:
TrustSignature
packets on signatures per RFC 4880 5.2.3.13It does not appear to me that this library models trust, so nothing is actually done with the additional trust information except preserve it on the
Signature
.