generateForwardingMaterial: proxy all encryption keys
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
force-pushed
the
forwarding-multiple-subkeys
branch
from
1d78681
to
7b9d103
Compare
marinthiercelin
approved these changes
Aug 8, 2023
…SupportForwarding` Previously, we only proxied the first encryption subkey. Now, the generated forwardee key will include a subkey for each encryption key of the forwarder key. Multiple proxy parameters will also be returned. Due to the change, we enforce that all encryption [sub]keys are compatible with forwarding.
larabr
force-pushed
the
forwarding-multiple-subkeys
branch
from
7b9d103
to
23856c1
Compare
twiss
approved these changes
Aug 9, 2023
larabr
added a commit
to larabr/pmcrypto
that referenced
this pull request
Feb 20, 2024
…SupportForwarding` (ProtonMail#182) Previously, we only proxied the first encryption subkey. Now, the generated forwardee key will include a subkey for each encryption key of the forwarder key. Multiple proxy parameters will also be returned. Due to the change, we enforce that all encryption [sub]keys are compatible with forwarding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add
doesKeySupportForwarding.Previously, we only proxied the first encryption subkey. Now, the generated forwardee key will include a subkey for each encryption key of the forwarder key. Multiple proxy parameters will also be returned.
Due to the change, we enforce that all encryption [sub]keys are compatible with forwarding.