This repository has been archived by the owner on Nov 19, 2021. It is now read-only.
Fix signup not setting subscription with BF coupon #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincaslt
commented
Nov 8, 2019
vincaslt
commented
- Coupon which still had leftover amount to pay (BF) did not pass it when subscribing, so it was failing.
- When plans were bundled, I forgot to add the bundled plan info in addition to fake bundle plan.
vincaslt
commented
Nov 8, 2019
| @@ -140,9 +140,11 @@ const useSignup = (onLogin, { coupon, invite, availablePlans = VPN_PLANS } = {}, | |||
|
|
|||
| const bundlePlans = | |||
| bundle && plans.filter(({ Name, Type }) => Type === PLAN_TYPES.PLAN && bundle.includes(Name)); | |||
| const bundlePlan = bundle && (await getPlansWithCoupon(bundlePlans, model.planName)); | |||
| const bundlePlan = bundle && getPlansWithCoupon(bundlePlans, model.planName); | |||
There was a problem hiding this comment.
Irrelevant change really, but it was unnecessary to wait for promise here.
vincaslt
commented
Nov 8, 2019
| } else if (paymentDetails) { | ||
| return { Token: paymentDetails.VerifyCode, TokenType: TOKEN_TYPES.PAYMENT }; | ||
| } else if (coupon) { |
There was a problem hiding this comment.
Coupon used to take priority, and payment details would not be applied, but there would still be some amount to pay, so it failed to signup. This is an oversight because I was testing with coupons that had 100% discount...
EpokK
approved these changes
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.