Add in-tree Flatpak support (are you interested in providing a Flatpak manifest?) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took the Flatpak manifest from https://github.com/flathub/com.protonvpn.www and converted it to JSON for this, so that it can be used by GNOME Builder for local Flatpak builds. Credits to @proletarius101 for the original work! GNOME Builder only supports the JSON format. Builder is the recommended IDE for developers building GTK and GNOME apps. It has built-in support for Flatpak builds with just a click. https://wiki.gnome.org/Newcomers/BuildProject Making it easy for the GNOME/GTK community to build your app can attract valuable contributors. In the future, if there's interest, this same Flatpak manifest could be used by a GitHub Action to produce a Flatpak bundle out of a CI job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand if you don't want to commit now to maintaining yet another build specification. 馃槃
I was trying your app out and decided the easiest way for me to test the latest commit was with a Flatpak build, so I went ahead and did what I am proposing in this PR regardless. Feel free to close the PR. 馃榾
But if you decide to go in this direction, you'd be great to contact the maintainer of the unofficial ProtonVPN app on Flathub and propose a collaboration. The manifest there could be synced with this one here.
With these files in-tree I was able to open GNOME Builder, enter this repository URL, click Play, wait for the build and success! The app launched!
Add in-tree Flatpak support
I took the Flatpak manifest from
https://github.com/flathub/com.protonvpn.www and converted it to JSON for this, so that it can be used by GNOME Builder for local Flatpak builds. Credits to @proletarius101 for the original work!
GNOME Builder only supports the JSON format.
Builder is the recommended IDE for developers building GTK and GNOME apps. It has built-in support for Flatpak builds with just a click. https://wiki.gnome.org/Newcomers/BuildProject
Making it easy for the GNOME/GTK community to build your app can attract valuable contributors. This also helps you have reproducible builds across different environments.
In the future, if there's interest, this same Flatpak manifest could be used by a GitHub Action to produce a Flatpak bundle out of a CI job.