Reject potentially unsafe characters in .aleo and .leo files
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformulate some rules to exclude potentially unsafe ASCII and non-ASCII characters. Matches the current Aleo instruction parser (see https://github.com/AleoHQ/snarkVM/pull/1044).
acoglio
changed the title
.aleo files.aleo files
Reformulate some rules to exclude potentially unsafe ASCII characters. The exclusion is the same as in Aleo instructions.
acoglio
changed the title
.aleo files.aleo and .leo files
bendyarm
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
I double-checked all the details and I think it is all correct.
The change is a good one. There is no reason to allow the nonprintable ASCII control characters in the source code's language.
One suggestion I have is to add comments near the beginning of the file that (1) link to the ABNF spec and (2) explain that the source code files must be in valid UTF-8 which is first decoded to code points before it is parsed with this grammar. For example, see the first two comments in this file: https://github.com/toml-lang/toml/blob/main/toml.abnf
|
@bendyarm Adding that kind of comment seems like a good idea. I've just opened an Issue for that. |
d0cd
approved these changes
Oct 25, 2022
acoglio
added a commit
that referenced
this pull request
Jan 5, 2023
Add references to ABNF notation. Specify that the grammar applies to UTF-8-decoded files. Closes #4.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors https://github.com/AleoHQ/snarkVM/pull/1044, for Aleo instructions.
Mirrors Aleo instructions for Leo, but we still need to modify the Leo parser (actually lexer) for this.