Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 11 importing PSX bin files #637

Closed
ExcalibaX3 opened this issue Jan 1, 2018 · 15 comments
Closed

iOS 11 importing PSX bin files #637

ExcalibaX3 opened this issue Jan 1, 2018 · 15 comments

Comments

@ExcalibaX3
Copy link

Hello
I have a current problem with importing PSX bin files as the are imported as SEGA GENISIS files
Please thank you

@jasarien
Copy link
Member

jasarien commented Jan 1, 2018

Please make sure you are importing the PSX ROMs including a .cue sheet file that is zipped together with the bin files, and not the bin files by themselves.

Also, please ensure that the cue files and bin files have the same file names before their extensions and that the contents of the cue sheet correctly references the bin files by file name.

@QuarterSwede
Copy link

QuarterSwede commented Jan 1, 2018 via email

@jasarien
Copy link
Member

jasarien commented Jan 1, 2018

https://github.com/jasarien/Provenance/wiki/Playstation-Instructions

It doesn’t quite fit into a dialog.

@QuarterSwede
Copy link

QuarterSwede commented Jan 1, 2018 via email

@sevdestruct
Copy link
Collaborator

sevdestruct commented Jan 2, 2018

Perhaps a the simple solution might just be to modify the bottom of the games list (which easily shows when no games are yet added especially) and/or the header of the web server with note that links this info…similar to what OpenEmu does when it's empty and/or first-time-use.

OpenEmu


screen shot 2018-01-01 at 4 48 15 pm

OpenEmu: "Check out this guide to on how to add disc-based games."

@sevdestruct
Copy link
Collaborator

sevdestruct commented Jan 2, 2018

Based on the articles Provenance currently has maybe this would be an example of a solve for the web server (a note in the iOS app near the Import ROMs button in tvOS and in the pop-up dialogue after clicking + in iOS or both might be a nice solve without the need for coding in a prompt based on the file type just yet)…

Web Server:
provenance-web-server-addition

iOS:
[note in Web server started! dialogue]

tvOS:
[note near Import ROMs button and/or in Web server started! dialogue.]


Upload multi-file ROMs as single-file .zip archives. Check these guides for how to add disc-based games: Playstation | Sega CD

@sevdestruct
Copy link
Collaborator

Submitted some updates just now to master based on the above I hope will alleviate the learning curve or upload mistakes in this. (first contribution!)

…also I did some additional cleanup in Settings view while I was in there—noticed a lot of inconsistent type sizes and table cells, and discrepancies between tvOS and iOS wording in the buttons and descriptions - proposing some condensed rewrites too.

Hope the additions help newcomers.

@sevdestruct
Copy link
Collaborator

Might also submit another change today to add the "Upload multi-file ROMs as single-file .zip archives. " to the "Web server started!" dialogue, to address the use of the + button as aopposed to using Import/Export > in Settings, as mentioned by @QuarterSwede.

@jasarien
Copy link
Member

jasarien commented Jan 4, 2018

@sevdestruct Where are you “submitting” these changes? Unless you create a pull request, they’re not going to go anywhere beyond your own checkout.

@sevdestruct
Copy link
Collaborator

sevdestruct commented Jan 4, 2018

@jasarien Oh I'm new to GitHub. I made some changes in xcode and then selected those files in GitHub Desktop and clicked Submit to master. Let me see about a pull request..

@sevdestruct
Copy link
Collaborator

@jasarien : continued working on this, but still not sure how to do a pull request. Little help?

@jasarien
Copy link
Member

jasarien commented Jan 4, 2018

It’s not quite so simple that I can explain everything here. But basically:

  • fork the Provenance repository
  • create a new branch on which you commit your changes
  • create a pull request to merge your branch into the main Provenance repo

You can read many topics about the process here: https://help.github.com/categories/collaborating-with-issues-and-pull-requests/

If you’re not already familiar with how git works, then you will need to learn more about branching and merging.

@sevdestruct
Copy link
Collaborator

sevdestruct commented Jan 4, 2018

@jasarien I found a tutorial while you were writing it seems. Thanks though. I forked the project, and committed the changes, and made the pull request. Time to sleep…

jasarien added a commit that referenced this issue Jan 22, 2018
Updates for Issue #637: Revisions to Settings View(s), Web Server Active Alert View(s) (iOS, tvOS) + Enabled In-App use of Web Server (iOS only)
@jasarien
Copy link
Member

Sev’s PRs have been merged, so I’ll close this issue.

@sevdestruct
Copy link
Collaborator

sevdestruct commented Jan 24, 2018

Thanks, @jasarien! …I think my PRs will help steer people into the right place for info and the web server access from in-app that is now enabled/added will help them resolve it themselves as a workaround for now, but I think the larger issue here is not yet resolved, as .bin/.cue files are still getting separated into the wrong places oftentimes even regardless of putting in archive beforehand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants