Fixed ScrapeAppReviews total being resolved twice in the case where a…

…n unrelated exception occurs after successful resoltion.
Provider · Jan 19, 2020 · 3afef84 · 3afef84
1 parent 94496e6
commit 3afef84
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/Resource/ScrapeAppReviews.php b/src/Resource/ScrapeAppReviews.php
@@ -47,9 +47,10 @@ public function getProviderClassName(): string
     public function fetchAsync(ImportConnector $connector): Iterator
     {
         $total = new Deferred();
+        $resolved = false;
 
         return new AsyncGameReviewsRecords(
-            new Producer(function (\Closure $callable) use ($connector, $total): \Generator {
+            new Producer(function (\Closure $callable) use ($connector, $total, $resolved): \Generator {
                 do {
                     try {
                         /** @var HttpResponse $response */
@@ -63,9 +64,14 @@ public function fetchAsync(ImportConnector $connector): Iterator
 
                         if (isset($json['review_score'])) {
                             $total->resolve($this->parseResultsTotal($json['review_score']));
+                            $resolved = true;
                         }
                     } catch (\Throwable $throwable) {
-                        $total->fail($throwable);
+                        if (!$resolved) {
+                            $total->fail($throwable);
+                        }
+
+                        throw $throwable;
                     }
 
                     if ($json['recommendationids']) {