GimmePeers Blah Query Value Update #338
Conversation
GP recently released an updated IMDB ID search option for queries. This change was added because queries against "blah=3" were turning up inconsistent results because not all "title" or "NFO" contained the IMDb. The default "blah" value in the gimmepeers.yaml file is 3, but it should now be changed to 4.
definitions/v7/gimmepeers.yml
Outdated
| @@ -96,8 +96,8 @@ search: | |||
| inputs: | |||
| $raw: "{{ range .Categories }}c{{.}}=1&{{end}}" | |||
| search: "{{ if .Query.IMDBID }}{{ .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.Genre }} genre:{{ .Query.Genre }}{{ else }}{{ end }}" | |||
| # 0 title, 1 nfo, 2 filelist, 3 title+nfo | |||
| blah: "{{ if or .Query.IMDBID .Query.Genre }}3{{ else }}0{{ end }}" | |||
| # 0 title, 1 nfo, 2 filelist, 3 title+nfo, 4 IMDB (tt#) | |||
There was a problem hiding this comment.
Is this imdbid only or also for genre?
If it's not for both then the condition will need to be changed
There was a problem hiding this comment.
Good point! I overlooked the Genre. This change is only for the IMDb id. I haven't had to dig into these indexers before, but I requested GP to make this change for IMDb, so I figured I could take the extra step to request the indexer to be updated.
Would this line do the trick?
blah: "{{ if .Query.IMDBID }}4{{ else }}0{{ end }}{{ if .Query.Genre }}3{{ else }}0{{ end }}"
Revised the "blah" line to only set 4 when the IMDb id is queried, but continue to use "blah=3" for Genre.
Revised to match the Jackett update for the same "blah" query. Jackett/Jackett@927ffdf
|
Good stuff! I updated my PR to match the one submitted with Jackett. I had also forked the Jackett repo and planned on updating that one after I verified this one was good. We both were trying to get this updated quickly. |
Indexer/Tracker
https://github.com/Prowlarr/Indexers/blob/master/definitions/v7/gimmepeers.yml
Description
GP recently released an updated IMDb ID search option for queries. This change was added because queries against "blah=3" were turning up inconsistent results because not all "title" or "NFO" contained the IMDb. The default "blah" value in the gimmepeers.yaml file is 3, but it should now be changed to 4.
Issues Fixed or Closed by this PR
Revised "blah" value for better matches.