Skip to content

Commit

Permalink
Fixed: Don't disable IPv6 in IPv6-only Environment
Browse files Browse the repository at this point in the history
(cherry picked from commit 13af6f57796e54c3949cf340e03f020e6f8575c4)
  • Loading branch information
covert8 authored and mynameisbogdan committed Mar 3, 2024
1 parent cc85060 commit a25e790
Showing 1 changed file with 16 additions and 4 deletions.
20 changes: 16 additions & 4 deletions src/NzbDrone.Common/Http/Dispatchers/ManagedHttpDispatcher.cs
@@ -1,8 +1,10 @@
using System;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Net;
using System.Net.Http;
using System.Net.NetworkInformation;
using System.Net.Security;
using System.Net.Sockets;
using System.Text;
Expand Down Expand Up @@ -275,6 +277,18 @@ private CredentialCache GetCredentialCache()
return _credentialCache.Get("credentialCache", () => new CredentialCache());
}

private static bool HasRoutableIPv4Address()
{
// Get all IPv4 addresses from all interfaces and return true if there are any with non-loopback addresses
var networkInterfaces = NetworkInterface.GetAllNetworkInterfaces();

return networkInterfaces.Any(ni =>
ni.OperationalStatus == OperationalStatus.Up &&
ni.GetIPProperties().UnicastAddresses.Any(ip =>
ip.Address.AddressFamily == AddressFamily.InterNetwork &&
!IPAddress.IsLoopback(ip.Address)));
}

private static async ValueTask<Stream> onConnect(SocketsHttpConnectionContext context, CancellationToken cancellationToken)
{
// Until .NET supports an implementation of Happy Eyeballs (https://tools.ietf.org/html/rfc8305#section-2), let's make IPv4 fallback work in a simple way.
Expand All @@ -298,10 +312,8 @@ private static async ValueTask<Stream> onConnect(SocketsHttpConnectionContext co
}
catch
{
// very naively fallback to ipv4 permanently for this execution based on the response of the first connection attempt.
// note that this may cause users to eventually get switched to ipv4 (on a random failure when they are switching networks, for instance)
// but in the interest of keeping this implementation simple, this is acceptable.
useIPv6 = false;
// Do not retry IPv6 if a routable IPv4 address is available, otherwise continue to attempt IPv6 connections.
useIPv6 = !HasRoutableIPv4Address();
}
finally
{
Expand Down

0 comments on commit a25e790

Please sign in to comment.