Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo: Restore Rarbg HTTP 200 Rate Limiting [Waiting on Rarbg] #1277

Closed
1 task done
bakerboy448 opened this issue Jan 2, 2023 · 1 comment · Fixed by #1422
Closed
1 task done

ToDo: Restore Rarbg HTTP 200 Rate Limiting [Waiting on Rarbg] #1277

bakerboy448 opened this issue Jan 2, 2023 · 1 comment · Fixed by #1422
Labels
Area: Indexer Issue is related to indexers. Type: External Bug A third party app broke something, GHI is open for informational purposes Type: Regression Regression due to commit

Comments

@bakerboy448
Copy link
Contributor

bakerboy448 commented Jan 2, 2023

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Is your feature request related to a problem? Please describe

Restore HTTP 200 & rate_limit 1 as too many requests.

reverted 5cc044a#diff-bd56c63a2154391186c3916be78aa2c0b6de3dca774930b0a4cb99b29d1b8425L46

Due to false positive rate_limit of 1 with 200s when no rate limit was actually occurring (results were found)

awaiting internal fix from rarbg for false positive

Describe the solution you'd like

if the API returns 200 with a json that contains rate_limit 1 retry in 5 minutes
#1169

Describe alternatives you've considered

N/A

Anything else?

N/A

AB#4613

@bakerboy448 bakerboy448 added Type: External Bug A third party app broke something, GHI is open for informational purposes Area: Indexer Issue is related to indexers. Type: Regression Regression due to commit labels Jan 2, 2023
bakerboy448 added a commit to bakerboy448/Prowlarr that referenced this issue Feb 11, 2023
bakerboy448 added a commit to bakerboy448/Prowlarr that referenced this issue Feb 11, 2023
bakerboy448 added a commit to bakerboy448/Prowlarr that referenced this issue Feb 11, 2023
bakerboy448 added a commit to bakerboy448/Prowlarr that referenced this issue Feb 11, 2023
bakerboy448 added a commit to bakerboy448/Prowlarr that referenced this issue Feb 11, 2023
bakerboy448 added a commit to bakerboy448/Prowlarr that referenced this issue Feb 11, 2023
bakerboy448 added a commit to bakerboy448/Prowlarr that referenced this issue Feb 12, 2023
mynameisbogdan pushed a commit that referenced this issue Feb 18, 2023
@bakerboy448
Copy link
Contributor Author

bakerboy448 commented Feb 19, 2023

for posterity and context in the future

there are multiple levels of late limiters
cloudflare -> web -> code

when rated limited cloudflare will return http code 429 with a json encoded string that includes rate limit 1
when rated limited web returns http code 444 to cloudflare which returns 520 on cloudflare , there is no way to send 429 to cloudflare without it breaking the request properly and retrying it
when rated limited code returns http code 200 with rate_limit 1

rate_limit : 1 is generally returned when you've exceeded the rate limit or when one of the many servers behind cloudflare is being overloaded - because cloudflare doesn't evenly redistribute requests equally its there so clients via api can see that they are rate limited , retry in lets say 5 seconds and they can get their request fullfilled on another backend ( cloudflare doesn't do stickiness ) in x time

Originally posted by rarbg in Jackett/Jackett#13663 (comment)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Indexer Issue is related to indexers. Type: External Bug A third party app broke something, GHI is open for informational purposes Type: Regression Regression due to commit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant