fix(TableMapping): make own non Camel Case Converter for Cookies #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevYukine
changed the title
|
Just manually confirmed it does indeed fix the mentioned issue for me locally :) |
Qstick
approved these changes
Jun 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
The current way of storing Cookies persistently is broken because the Cookies IDictionary<string, string> has a CamelCase Key Police. This results in the cookie key being converted to Camel Case which kills the cookie for some sites (like AnimeTorrents)
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR
Fixes #217