Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: (Orpheus) Drop Book Support due to invalid Responses #973

Closed
wants to merge 1 commit into from
Closed

Fixed: (Orpheus) Drop Book Support due to invalid Responses #973

wants to merge 1 commit into from

Conversation

bakerboy448
Copy link
Contributor

Database Migration

NO

Description

drops book support for Orpheus to work around invalid - non gazelle standard - responses.
Orpheus has yet to indicate if their non-standard changes are intentional or not.

Screenshot (if UI related)

Todos

  • Tests
  • Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)
  • Wiki Updates

Issues Fixed or Closed by this PR

@bakerboy448 bakerboy448 requested a review from ta264 April 28, 2022 20:17
ta264
ta264 requested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@ta264 ta264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete it, don't leave the commented out code.

If you really want you can leave a text comment saying "book categories omitted due to invalid dates" or something similar

@bakerboy448
Copy link
Contributor Author

Just delete it, don't leave the commented out code.

If you really want you can leave a text comment saying "book categories omitted due to invalid dates" or something similar

done

@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bakerboy448 bakerboy448 requested a review from ta264 April 29, 2022 23:40
@bakerboy448 bakerboy448 added Status: Ready for Review Awaiting review Area: Indexer Issue is related to indexers. labels May 1, 2022
@Qstick Qstick closed this in 95a2bd3 May 20, 2022
@Qstick Qstick deleted the bakerboy448-patch-1 branch February 26, 2023 07:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ta264 ta264 Awaiting requested review from ta264

Assignees
No one assigned
Labels
Area: Indexer Issue is related to indexers. Status: Ready for Review Awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orpheus - Invalid & Unparsable DateTime Returned
2 participants
@bakerboy448 @ta264