Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing titles and styles #4

Closed
kgp43 opened this issue Dec 27, 2020 · 4 comments
Closed

Missing titles and styles #4

kgp43 opened this issue Dec 27, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@kgp43
Copy link
Contributor

kgp43 commented Dec 27, 2020

Hi,

Thanks for this package - makes it quite easy to get started :)
Got a few problems though.

I'm not able to see the "change password" titles and the 2FA button is also looking weird.
Rest seems fine.

What can be the reason for this?

image

roelreijneveld added a commit that referenced this issue Dec 27, 2020
Replace language strings, add styles and improve the 2fa-switch order.
@roelreijneveld
Copy link
Member

Hi @kgp43

Thanks for pointing out those mistakes!

I've released a new version (v1.1.1) which fixes those issues. You should be able to install those updates by running composer update and php artisan fortify-ui:tabler-update. Please note that running the second command will override certain files previously installed by the installer.

Please let me know if you have any further questions!

@roelreijneveld roelreijneveld added the bug Something isn't working label Dec 27, 2020
@kgp43
Copy link
Contributor Author

kgp43 commented Dec 28, 2020

Hi Roel,

That was fast and worked perfectly!
Thanks a lot for the detailed update instructions.

Love this package :)

@kgp43
Copy link
Contributor Author

kgp43 commented Dec 28, 2020

Hi @RoelReijn

I found one more minor bug (very small).
It seems there is missing a closing div on this part within the home view:

<div class="card-body"> <div class="alert alert-success"> Hi there! Thank you for using the .... </div>

This: <div class="alert alert-success"> does not have a closing div.
If I add a closing div, then the footer is moved down a bit.

It works fine as it is, but my editor (VS Code) tells me the page is missing a closing div (home.blade.php)

roelreijneveld added a commit that referenced this issue Dec 28, 2020
As seen in issue #4

Co-Authored-By: kgp43 <15347427+kgp43@users.noreply.github.com>
@roelreijneveld
Copy link
Member

Hi @kgp43

Hi Roel,

That was fast and worked perfectly!
Thanks a lot for the detailed update instructions.

Love this package :)

Thanks a lot!

Hi RoelReijn

I found one more minor bug (very small).
It seems there is missing a closing div on this part within the home view:

<div class="card-body"> <div class="alert alert-success"> Hi there! Thank you for using the .... </div>

This: <div class="alert alert-success"> does not have a closing div.
If I add a closing div, then the footer is moved down a bit.

It works fine as it is, but my editor (VS Code) tells me the page is missing a closing div (home.blade.php)

Thanks for noticing. I'm about to release a new version which includes a bug fix. Please note that the update command has changed to php artisan tabler:update --type=full as you will be able to see in the README.md file.

I will close this issue now but please open a new issue if you find other bugs or if you have ideas for a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants