Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If login event was cancelled but redis bungee will see it as not cancelled #12

Closed
licen150 opened this issue Jul 1, 2021 · 2 comments · Fixed by #16
Closed

If login event was cancelled but redis bungee will see it as not cancelled #12

licen150 opened this issue Jul 1, 2021 · 2 comments · Fixed by #16
Assignees
@ham1255
Labels
bug Something isn't working completed Finished! help wanted Extra attention is needed priority: High Pull Request Available

Comments

@licen150
Copy link

licen150 commented Jul 1, 2021

Hello, im using Litebans plugin on bungee. If banned tried to connect to server he makes +1 to server online for 1+ min. Im using Bungeecord BotFilter. Latest RedisBungee build and Reds 6.2.4.
image
@ham1255 ham1255 added bug Something isn't working help wanted Extra attention is needed priority: High and removed waiting labels Jul 21, 2021
@ham1255
Copy link
Member

ham1255 commented Jul 21, 2021 •
edited

sorry for being late on this. i had some personal issues to solve.
and also please next time follow the issue template.
anyways....
so after further testing.... it seems redis-bungee does not even know if the event was cancelled. due being async which bad
i am thinking moving to postlogin should better.

@ham1255 ham1255 linked a pull request Jul 21, 2021 that will close this issue
Fix: Player being added into the Redis database if LoginEvent was cancelled..... #16
Merged
@ham1255
Copy link
Member

ham1255 commented Jul 21, 2021

try out this build. https://github.com/Limework/RedisBungee/suites/3298035448/artifacts/77054655

@ham1255 ham1255 changed the title Banned players can make +1 to server online If login event was cancelled but redis bungee will see it as not cancelled Jul 21, 2021
@ham1255 ham1255 added the completed Finished! label Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ham1255 ham1255

Labels
bug Something isn't working completed Finished! help wanted Extra attention is needed priority: High Pull Request Available
Projects
None yet
Milestone
No milestone
2 participants
@ham1255 @licen150