Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Player being added into the Redis database if LoginEvent was cancelled..... #16

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

ham1255
Copy link
Member

@ham1255 ham1255 commented Jul 21, 2021

This PR also might fix frequent You are already logged on to this server which make the player wait till he can join back.

@ham1255 ham1255 requested a review from a user July 21, 2021 20:32
@ham1255 ham1255 self-assigned this Jul 21, 2021
@ham1255 ham1255 added bug Something isn't working waiting labels Jul 21, 2021
@ham1255
Copy link
Member Author

ham1255 commented Jul 21, 2021

merging this it seems that redis-bungee does better with this.

@ham1255 ham1255 closed this Jul 21, 2021
@ham1255 ham1255 reopened this Jul 21, 2021
@ham1255
Copy link
Member Author

ham1255 commented Jul 21, 2021

oops

@ham1255 ham1255 merged commit 86ebc9c into master Jul 21, 2021
@ham1255
Copy link
Member Author

ham1255 commented Jul 21, 2021

it seem this fixed more than a thing like this message never showed up before.
Screenshot from 2021-07-22 02-07-18

@ham1255 ham1255 deleted the fix_login_issues branch July 21, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed Finished!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If login event was cancelled but redis bungee will see it as not cancelled
1 participant