feat: chatgpt optimize utils

src/base-system.ts

@@ -9,6 +9,7 @@ import {
   BodyOptions,
   ChildrenData,
   Data,
+  InTest,
   Leaf,
   PotentialVector,
   RBush,
@@ -185,7 +186,7 @@ export class BaseSystem<TBody extends Body = Body>
   /**
    * remove body aabb from collision tree
    */
-  remove(body: TBody, equals?: (a: TBody, b: TBody) => boolean): RBush<TBody> {
+  remove(body: TBody, equals?: InTest<TBody>): RBush<TBody> {
     body.system = undefined;
 
     return super.remove(body, equals);

src/intersect.ts

@@ -68,15 +68,15 @@ export function pointOnCircle(
  * https://stackoverflow.com/a/68197894/1749528
  */
 export function circleInCircle(
-  a: Pick<Circle, "pos" | "r">,
-  b: Pick<Circle, "pos" | "r">,
+  bodyA: Pick<Circle, "pos" | "r">,
+  bodyB: Pick<Circle, "pos" | "r">,
 ) {
-  const x1 = a.pos.x;
-  const y1 = a.pos.y;
-  const x2 = b.pos.x;
-  const y2 = b.pos.y;
-  const r1 = a.r;
-  const r2 = b.r;
+  const x1 = bodyA.pos.x;
+  const y1 = bodyA.pos.y;
+  const x2 = bodyB.pos.x;
+  const y2 = bodyB.pos.y;
+  const r1 = bodyA.r;
+  const r2 = bodyB.r;
   const distSq = Math.sqrt((x1 - x2) * (x1 - x2) + (y1 - y2) * (y1 - y2));
 
   return distSq + r2 === r1 || distSq + r2 < r1;

src/model.ts

@@ -205,6 +205,11 @@ export type SATTest<
   Y extends {} = Circle | Polygon | SATPolygon,
 > = (bodyA: T, bodyB: Y, response: Response) => boolean;
 
+export type InTest<TBody extends Body = Body> = (
+  bodyA: TBody,
+  bodyB: TBody,
+) => boolean;
+
 export type TraverseFunction<TBody extends Body = Body> = (
   child: Leaf<TBody>,
   children: Leaf<TBody>[],

src/system.spec.js

@@ -32,8 +32,6 @@ describe("GIVEN System", () => {
 
     // <-- works
     physics.checkAll(({ a, b }) => {
-      console.log({ a: a.pos, b: b.pos });
-
       // <-- doesn't collide or run this code
       expect(true).toBe(false);
     });

src/system.ts

@@ -126,7 +126,7 @@ export class System<TBody extends Body = Body> extends BaseSystem<TBody> {
       return false;
     }
 
-    const sat = getSATTest(bodyA, bodyB) as SATTest;
+    const sat = getSATTest(bodyA, bodyB);
 
     // 99% of cases
     if (bodyA.isConvex && bodyB.isConvex) {