Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use better typings of consola once they are fixed #63 #73

Merged
merged 5 commits into from May 8, 2020
Merged

chore: use better typings of consola once they are fixed #63 #73

merged 5 commits into from May 8, 2020

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented May 8, 2020

Fix #63

@regevbr regevbr self-assigned this May 8, 2020
@regevbr regevbr added chore Make the code better pending code review pending code review labels May 8, 2020
@regevbr regevbr requested a review from ynahmany May 8, 2020 18:26
@regevbr
Copy link
Contributor Author

regevbr commented May 8, 2020

@ynahmany can you please CR this?

@codecov
Copy link

codecov bot commented May 8, 2020 •
edited

Codecov Report

Merging #73 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   97.23%   97.24%   +0.01%     
==========================================
  Files          79       80       +1     
  Lines        1519     1527       +8     
  Branches      189      189              
==========================================
+ Hits         1477     1485       +8     
  Misses         42       42
Flag Coverage Δ
#unittest 97.24% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
src/utils/logger/interfaces/ILoggerSettings.ts 100.00% <ø> (ø)
src/utils/logger/impl/logLevel.ts 100.00% <100.00%> (ø)
src/utils/logger/impl/logReporter.ts 100.00% <100.00%> (ø)
src/utils/logger/impl/logger.ts 100.00% <100.00%> (ø)
src/utils/logger/impl/loggerFactory.ts 100.00% <100.00%> (ø)
src/utils/logger/interfaces/ILogger.ts 100.00% <100.00%> (ø)

@regevbr regevbr merged commit 56bedde into master May 8, 2020
@regevbr regevbr deleted the #63 branch May 8, 2020 20:29
@regevbr
Copy link
Contributor Author

regevbr commented May 8, 2020

thanks @ynahmany

@regevbr regevbr removed the pending code review pending code review label May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ynahmany ynahmany ynahmany approved these changes

Assignees

@regevbr regevbr

Labels
chore Make the code better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: use better typings of consola once they are fixed
2 participants
@regevbr @ynahmany