Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Torch God's Facor to place biome torch and campfire #2811

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Allow Torch God's Facor to place biome torch and campfire #2811

merged 3 commits into from
Nov 10, 2022

Conversation

sgkoishi
Copy link
Contributor

@sgkoishi sgkoishi commented Nov 6, 2022

hakusaro
hakusaro reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@hakusaro hakusaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but the changelog has too many entries. Can you reduce the changelog to only things that have changed in this PR?

@sgkoishi
Copy link
Contributor Author

sgkoishi commented Nov 7, 2022

Still two lines left but one of them is for #2809 controlled by the bot, would it be fine?

@hakusaro
Copy link
Member

Still two lines left but one of them is for #2809 controlled by the bot, would it be fine?

eh?

@sgkoishi
Copy link
Contributor Author

Still two lines left but one of them is for #2809 controlled by the bot, would it be fine?

eh?

The second line Allowed Crystal Shard to grow is for #2809 . Or maybe I just remove that line?

@hakusaro hakusaro merged commit 01917d4 into Pryaxis:general-devel Nov 10, 2022
@sgkoishi sgkoishi deleted the pr2811 branch November 20, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakusaro hakusaro Awaiting requested review from hakusaro

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgkoishi @hakusaro