Implement updates of deployment when echo changes #33
Conversation
Implements updating the replicas field for the deployment when the accociated echo resource gets updated.
AlexanderThaller
force-pushed
the
master
branch
from
1ccd903
to
c672c93
Compare
|
Thank you for your contribution. I'll review tomorrow. |
| let deployment = deployment_api.get(&echo.name_any()).await?; | ||
|
|
||
| if deployment.spec.expect("expected spec to be set").replicas != Some(echo.spec.replicas) { | ||
| Ok(EchoAction::Update) |
There was a problem hiding this comment.
There's a difference between patch and update, as described e.g. here https://kubernetes.io/docs/reference/using-api/api-concepts/#patch-and-apply
The action is named update, yet it performs a patch.
|
|
||
| let deployment = deployment_api.get(&echo.name_any()).await?; | ||
|
|
||
| if deployment.spec.expect("expected spec to be set").replicas != Some(echo.spec.replicas) { |
There was a problem hiding this comment.
This repository contains a minimalistic custom resource, with one field only. Even in this case, the kubernetes API should be allowed to handle the diff, not the application code. Kubernetes itself compares the resources using resource version (update) or checks for conflicts (patch).
The patched resource should simply be serialized and sent in an HTTP Patch request, and let Kubernetes handle the rest. Checking parts of the resource locally would be a bad practice in general. Between the version comparison and the HTTP request, yet another change to the resource can be applied.
https://kubernetes.io/docs/reference/using-api/api-concepts/#patch-and-apply
|
Closing due to inactivity. Feel free to reopen. |
Implements updating the replicas field for the deployment when the accociated echo resource gets updated.
Not sure if this the best approach.