Skip to content

Issues: PsuAstro528/project-elizabethg60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25 Open 50 Closed
25 Open 50 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Could consider using slices, StackedArrays or LazyArrays
#76 opened Dec 5, 2023 by eford
Great set of figures
#75 opened Dec 5, 2023 by eford
Nice separation of plotting and calculations
#74 opened Dec 5, 2023 by eford
Is there a reason to start time mid-function?
#73 opened Dec 5, 2023 by eford
Filenames are good to include in function argument
#72 opened Dec 5, 2023 by eford
Is this the right calculation?
#71 opened Dec 5, 2023 by eford
For \phi near \pi/2, could get unnecessary floating point error
#70 opened Dec 5, 2023 by eford
conventions
#69 opened Dec 5, 2023 by eford
Degrees or Radians? East/West is positive?
#68 opened Dec 5, 2023 by eford
Docstrings before function
#67 opened Dec 5, 2023 by eford
Do you have find the downloads fail?
#66 opened Dec 5, 2023 by eford
Could be called by __init__()
#65 opened Dec 5, 2023 by eford
Keep tests separate
#64 opened Dec 5, 2023 by eford
Consider StaticVectors for constant 3 vectors in inner loops
#63 opened Nov 21, 2023 by eford
Setting to 0 would be safer than x-x
#62 opened Nov 21, 2023 by eford
Docstring go right before the function in Julia
#60 opened Nov 21, 2023 by eford
Can reorder for better accuracy and slight speed boost
#59 opened Nov 21, 2023 by eford
Might be able to merge parallel loops
#57 opened Nov 21, 2023 by eford
Rounding error risk
#56 opened Nov 21, 2023 by eford
Nice (but you probably don't want all these jld2 in your repo)
#54 opened Nov 21, 2023 by eford
Prioritize where to parallelize
#53 opened Oct 25, 2023 by eford
Are many of these calls to rotation_period passing the same value?
#49 opened Oct 25, 2023 by eford
Replace with call to stack to reduce allocations
#48 opened Oct 25, 2023 by eford
Code Review Summary
#38 opened Oct 9, 2023 by kyleneumann
Unit test of solar radius
#9 opened Oct 6, 2023 by kyleneumann
ProTip! Updated in the last three days: updated:>2024-07-03.