Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use update instead of query for get_messages method #51

Merged
merged 2 commits into from Sep 5, 2022
Merged

chore: use update instead of query for get_messages method #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b82e24
use update instead of query for get_messages method
Aug 31, 2022
3491974
remove query from tera candid js in aws
Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/aws/src/libs/dfinity/idls/tera/tera.did.ts
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ export default ({ IDL }: { IDL: any }) => {
[ConsumeMessageResponse],
[],
),
get_messages: IDL.Func([], [IDL.Vec(OutgoingMessagePair)], ['query']),
get_messages: IDL.Func([], [IDL.Vec(OutgoingMessagePair)], []),
get_nonces: IDL.Func([], [IDL.Vec(IDL.Nat)], ['query']),
remove_messages: IDL.Func(
[IDL.Vec(OutgoingMessagePair)],
Expand Down
6 changes: 3 additions & 3 deletions core/ic/src/tera/src/api/messages.rs
View file
Open in desktop
@@ -1,5 +1,5 @@
use candid::candid_method;
use ic_cdk_macros::{query, update};
use ic_cdk_macros::update;

use super::admin::is_authorized;
use crate::{
Expand All @@ -13,8 +13,8 @@ fn remove_messages(messages: Vec<OutgoingMessagePair>) -> RemoveMessagesResponse
STATE.with(|s| RemoveMessagesResponse(s.remove_messages(messages)))
}

#[query(name = "get_messages", guard = "is_authorized")]
#[candid_method(query, rename = "get_messages")]
#[update(name = "get_messages", guard = "is_authorized")]
#[candid_method(update, rename = "get_messages")]
fn get_messages() -> Vec<OutgoingMessagePair> {
STATE.with(|s| s.get_messages())
}
Expand Down
2 changes: 1 addition & 1 deletion core/ic/src/tera/tera.did
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ type StoreMessageResponse = variant { Ok : CallResult; Err : text };
service : {
authorize : (principal) -> ();
consume_message : (principal, vec nat8, vec nat) -> (ConsumeMessageResponse);
get_messages : () -> (vec OutgoingMessagePair) query;
get_messages : () -> (vec OutgoingMessagePair);
get_nonces : () -> (vec nat) query;
remove_messages : (vec OutgoingMessagePair) -> (ConsumeMessageResponse);
send_message : (principal, vec nat) -> (SendMessageResponse);
Expand Down