Skip to content

Commit

Permalink
improve tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Sébastien VIDAL committed Jul 29, 2019
1 parent 85d94ce commit 3e94179
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 17 deletions.
19 changes: 11 additions & 8 deletions test/3_Mediator.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ describe("Mediator", () => {

return mediator.init().then(() => {

strictEqual(typeof mediator.initialized, "boolean", "Generated mediator is not as expected");
strictEqual(mediator.initialized, true, "Generated mediator is not as expected");

return mediator.release();

}).then(() => {
Expand Down Expand Up @@ -131,11 +134,9 @@ describe("Mediator", () => {
return new Promise((resolve, reject) => {

mediator
.once("test", resolve);
.once("initialized", resolve);

mediator.init().then(() => {
mediator.emit("test");
}).catch(reject);
mediator.init().catch(reject);

});

Expand All @@ -147,17 +148,19 @@ describe("Mediator", () => {

return new Promise((resolve, reject) => {

mediator.once("test", () => {
reject(new Error("Should not fire this event"));
});
mediator
.once("test", () => {
reject(new Error("Should not fire this event"));
})
.once("released", resolve);

mediator.init().then(() => {
return mediator.release();
}).then(() => {

mediator.emit("test");

resolve();
return Promise.resolve();

}).catch(reject);

Expand Down
18 changes: 9 additions & 9 deletions test/6_Orchestrator.js
Original file line number Diff line number Diff line change
Expand Up @@ -731,11 +731,9 @@ describe("Orchestrator", () => {
return new Promise((resolve, reject) => {

orchestrator
.once("test", resolve);
.once("initialized", resolve);

orchestrator.init().then(() => {
orchestrator.emit("test");
}).catch(reject);
orchestrator.init().catch(reject);

});

Expand All @@ -747,17 +745,19 @@ describe("Orchestrator", () => {

return new Promise((resolve, reject) => {

orchestrator.once("test", () => {
reject(new Error("Should not fire this event"));
});
orchestrator
.once("test", () => {
reject(new Error("Should not fire this event"));
})
.once("released", resolve);

orchestrator.init().then(() => {
return orchestrator.release();
}).then(() => {

orchestrator.emit("test");
mediator.emit("test");

resolve();
return Promise.resolve();

}).catch(reject);

Expand Down

0 comments on commit 3e94179

Please sign in to comment.