Feat <back> <chat, websockets>: storing websockets and userIds + receiver joins DM Room when creating DM room #58

NelMasr · 2022-09-24T21:53:21Z

Every time a user connects, we store his socket ID and associate it to its userID.
Every time a user disconnects, we delete the entry from the array.

Every time a user connects, we store his socket ID and associate it to its userID. Every time a user disconnects, we delete the entry from the array.

Before, only the sender joined the room that was created, like a channel. But in a DM, both users have to join the channel. Now that we stock websockets, it is possible.

To make the receiver join the room only when he is connected

NelMasr · 2022-09-25T10:41:57Z

New feature in this PR (I decided to do it in this branch because it cannot work if this PR is not in main).
Now that we store websocket IDs for each user, we can make the receiver join the room if he is connected (if we find his websocket in our UsersWebsockets object)

Psycokwet · 2022-09-25T10:43:37Z

If you want, when you have this kind of issue, create a branch, from the one you did a pr on, and so, you can start working on dependant feature like that :) Just don't do a pr for the child branch before the other one did pass ! :)

New feature in this PR (I decided to do it in this branch because it cannot work if this PR is not in main). Now that we store websocket IDs for each user, we can make the receiver join the room if he is connected (if we find his websocket in our UsersWebsockets object)

thi-nguy · 2022-09-26T09:20:26Z

great tip, I'm having the same concern :)\

thi-nguy · 2022-09-26T09:35:56Z

Sorry I have no idea how the codes work :), so I can not say it's good or not.

Just one thing comes up to my mind. Should we propose some ways to test what you guys have done in a PR? (you can put it in the comments, a guide, or a test. Show us how to test the work, which results should we have, in console or whatever).

Otherwise with people like me, I don't understand the code and I don't know which result it should give, I feel it's kind of wasting time to read blindly and don't get much knowledge. Maybe I don't understand the code, but at least I should be able to see the results.

For example, from pure front-end, you guys can test it easily because it's visual. But with work in fusion, I created some tests for you either on the site, or in the console to prove that it works (with backend). It takes more time for me, but it helps people who does not work on it have some ideas on how it should work.

test : offerings tests for #58

Psycokwet

I don't see anything wrong appart from my comment, but as thi said, didn't know how to test this one ^^

backend/src/chat/chat.gateway.ts

Psycokwet

Aaah, I meant to approve, don't know what I did wrong sorry u_u'

DaiClement

~~I approve, but if you can make this little change.~~

DaiClement · 2022-09-26T14:05:46Z

backend/src/chat/chat.gateway.ts

+// @UseGuards(JwtWsGuard)
+// @SubscribeMessage(ROUTES_BASE.CHAT.BAN_USER_REQUEST)
+// async banUser(
+//   @MessageBody() data: { message: string; channelId: number },
+//   @UserPayload() payload: any,
+// ) {
+//
+// }


I suppose this is the next PR.
Next time try to separate them.

DaiClement · 2022-09-26T14:14:00Z

backend/shared/interfaces/ChatRoom.ts

I think you didn't change the file's name.
Can you change it ?

ah, i forgot.

DaiClement · 2022-09-26T14:22:03Z

backend/src/chat/chat.gateway.ts

@@ -49,7 +52,27 @@ export class ChatGateway {

  @WebSocketServer()
  server: Server;
+  async handleConnection(client: Socket) {


can you add the decorator ?
async handleConnection(@ConnectedSocket() client: Socket) {

DaiClement · 2022-09-26T14:22:19Z

backend/src/chat/chat.gateway.ts

+    }
+  }
+
+  handleDisconnect(client: Socket) {


same thing here

DaiClement

~~sorry, i ask for change of interface/charRoom.ts~~

DaiClement

Can you change the name of interfaces/ChatRoom.ts ?
Sorry for the multiple message. i am tired.

NelMasr · 2022-09-26T18:59:43Z

Can you change the name of interfaces/ChatRoom.ts ? Sorry for the multiple message. i am tired.

It is done, thank you!

DaiClement

I prefer all stuff concern user in user/something.
But i need your code, so i approve it 😅

DaiClement · 2022-09-26T19:34:59Z

backend/src/chat/chat.service.ts

@@ -24,7 +24,7 @@ export class ChatService {
    private usersRepository: Repository<User>,
    private userService: UsersService,
  ) {}
-  private static chatRoomList: ChatRoom[] = [];
+  public static userWebsockets: UsersWebsockets[] = [];


As we said by oral, i prefer having a userGateway.
But i need your code, so a approve it 😅

test : offerings tests for #58

Feat <back> <chat, websockets>: storing websockets and userIds + receiver joins DM Room when creating DM room

feat <back> <chat, websockets>: storing websockets and userIds

ac5e263

Every time a user connects, we store his socket ID and associate it to its userID. Every time a user disconnects, we delete the entry from the array.

NelMasr requested review from DaiClement, Psycokwet, mescande and thi-nguy September 24, 2022 21:53

NelMasr and others added 3 commits September 24, 2022 23:56

update <back> <chat, websockets>: cleaning comments and console.log

9734d44

feat <back> <chat, createDM>: both sender and receiver join room

0cf4cf8

Before, only the sender joined the room that was created, like a channel. But in a DM, both users have to join the channel. Now that we stock websockets, it is possible.

update <back> <chat, createDM>: added an if statement

2966fc4

To make the receiver join the room only when he is connected

NelMasr changed the title ~~Feat <back> <chat, websockets>: storing websockets and userIds~~ Feat <back> <chat, websockets>: storing websockets and userIds + receiver joins DM Room when creating DM room Sep 25, 2022

Merge branch 'main' into nad_back_getUserWebsockets

8a0eaae

NelMasr added a commit that referenced this pull request Sep 26, 2022

Merge pull request #65 from Psycokwet/so_up_nad_hotfix_get42login

7301e66

test : offerings tests for #58

Psycokwet reviewed Sep 26, 2022

View reviewed changes

backend/src/chat/chat.gateway.ts Show resolved Hide resolved

Psycokwet approved these changes Sep 26, 2022

View reviewed changes

Merge branch 'main' into nad_back_getUserWebsockets

f314039

DaiClement reviewed Sep 26, 2022

View reviewed changes

DaiClement approved these changes Sep 26, 2022

View reviewed changes

DaiClement reviewed Sep 26, 2022

View reviewed changes

DaiClement requested changes Sep 26, 2022

View reviewed changes

update, clean <back> <userWebsockets>: cleaning following Clement's PR

bab80c8

NelMasr requested a review from DaiClement September 26, 2022 18:59

DaiClement approved these changes Sep 26, 2022

View reviewed changes

DaiClement merged commit e86f28d into main Sep 26, 2022

DaiClement deleted the nad_back_getUserWebsockets branch September 26, 2022 19:37

DaiClement mentioned this pull request Sep 26, 2022

bug on main, on login #75

Closed

Psycokwet pushed a commit that referenced this pull request Oct 13, 2022

Merge pull request #65 from Psycokwet/so_up_nad_hotfix_get42login

36fc2e2

test : offerings tests for #58

Psycokwet pushed a commit that referenced this pull request Oct 13, 2022

Merge pull request #58 from Psycokwet/nad_back_getUserWebsockets

fd1ae46

Feat <back> <chat, websockets>: storing websockets and userIds + receiver joins DM Room when creating DM room

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat <back> <chat, websockets>: storing websockets and userIds + receiver joins DM Room when creating DM room #58

Feat <back> <chat, websockets>: storing websockets and userIds + receiver joins DM Room when creating DM room #58

NelMasr commented Sep 24, 2022

NelMasr commented Sep 25, 2022

Psycokwet commented Sep 25, 2022

thi-nguy commented Sep 26, 2022

thi-nguy commented Sep 26, 2022 •

edited

Loading

Psycokwet left a comment

Psycokwet left a comment

DaiClement left a comment •

edited

Loading

DaiClement Sep 26, 2022

DaiClement Sep 26, 2022

DaiClement Sep 26, 2022

DaiClement Sep 26, 2022

DaiClement Sep 26, 2022

DaiClement left a comment •

edited

Loading

DaiClement left a comment

NelMasr commented Sep 26, 2022

DaiClement left a comment

DaiClement Sep 26, 2022

Feat <back> <chat, websockets>: storing websockets and userIds + receiver joins DM Room when creating DM room #58

Feat <back> <chat, websockets>: storing websockets and userIds + receiver joins DM Room when creating DM room #58

Conversation

NelMasr commented Sep 24, 2022

NelMasr commented Sep 25, 2022

Psycokwet commented Sep 25, 2022

thi-nguy commented Sep 26, 2022

thi-nguy commented Sep 26, 2022 • edited Loading

Psycokwet left a comment

Choose a reason for hiding this comment

Psycokwet left a comment

Choose a reason for hiding this comment

DaiClement left a comment • edited Loading

Choose a reason for hiding this comment

DaiClement Sep 26, 2022

Choose a reason for hiding this comment

DaiClement Sep 26, 2022

Choose a reason for hiding this comment

DaiClement Sep 26, 2022

Choose a reason for hiding this comment

DaiClement Sep 26, 2022

Choose a reason for hiding this comment

DaiClement Sep 26, 2022

Choose a reason for hiding this comment

DaiClement left a comment • edited Loading

Choose a reason for hiding this comment

DaiClement left a comment

Choose a reason for hiding this comment

NelMasr commented Sep 26, 2022

DaiClement left a comment

Choose a reason for hiding this comment

DaiClement Sep 26, 2022

Choose a reason for hiding this comment

thi-nguy commented Sep 26, 2022 •

edited

Loading

DaiClement left a comment •

edited

Loading

DaiClement left a comment •

edited

Loading