Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

Always some moar #65

Merged
merged 5 commits into from Apr 2, 2017
Merged

Always some moar #65

merged 5 commits into from Apr 2, 2017

Conversation

HairyFotr
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.362% when pulling e1f8a1c on HairyFotr:alwaysSomeMoar into 982e1fb on Psywerx:master.

@codecov-io
Copy link

codecov-io commented Apr 1, 2017

Codecov Report

Merging #65 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   53.36%   53.36%           
=======================================
  Files          14       14           
  Lines         699      699           
=======================================
  Hits          373      373           
  Misses        326      326
Impacted Files Coverage Δ
src/regex.py 100% <ø> (ø) ⬆️
src/plugins/base.py 65.51% <0%> (ø) ⬆️
src/plugins/read_links.py 68.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982e1fb...0f978d2. Read the comment docs.

@HairyFotr HairyFotr requested a review from anze3db April 1, 2017 21:55
@anze3db
Copy link
Member

anze3db commented Apr 1, 2017

Can you increase code coverage? 50% of diff hit (target 53.36%)? :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 53.505% when pulling 0f978d2 on HairyFotr:alwaysSomeMoar into 982e1fb on Psywerx:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 53.505% when pulling 0f978d2 on HairyFotr:alwaysSomeMoar into 982e1fb on Psywerx:master.

@HairyFotr
Copy link
Member Author

I guess not on first try :D

@HairyFotr
Copy link
Member Author

I don't want to write a new test for PsywerxBot, mocking all the network stuff, also:

I tried

@anze3db
Copy link
Member

anze3db commented Apr 2, 2017

You gave it your best shot and failed miserably. The lesson is: Never try 😆

Thanks for making an effort!

@anze3db anze3db merged commit d8b2e83 into Psywerx:master Apr 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants