implement popular articles (http) #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
可以再到 Slack 上面邀請其他人幫忙 Review 喔 |
gn01842919
reviewed
Mar 2, 2021
| b, _ := json.MarshalIndent(responseMap, "", " ") | ||
| w.Write(b) | ||
| return | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
其實我也沒有覺得非要不可，只是覺得維持一致比較好，所以這邊是用單純的留言而沒有 request change
gn01842919
approved these changes
Mar 3, 2021
gn01842919
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決掉的 issue / Resolved Issues
📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes