Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get board information for usecase and delivery/http #127

Merged

Conversation

gogog22510
Copy link
Contributor

👏 解決掉的 issue / Resolved Issues

📝 相關的 issue / Related Issues

⛏ 變更內容 / Details of Changes

  • 實作 http/usecase
  • 測試 http/usecase

internal/usecase/board.go Outdated Show resolved Hide resolved
@wagaru
Copy link
Collaborator

wagaru commented Mar 11, 2021

LGTM

Copy link
Contributor

@Julian-Chu Julian-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo : limition should be limitation or limit

@gogog22510
Copy link
Contributor Author

我是參考API 文件上面的field.... 上面是寫post_limition, 我在文件上面建議改成post_limitation了,假如接受的話我可以一併改動

@PichuChen
Copy link
Member

我是參考API 文件上面的field.... 上面是寫post_limition, 我在文件上面建議改成post_limitation了,假如接受的話我可以一併改動

https://docs.google.com/document/d/18DsZOyrlr5BIl2kKxZH7P2QxFLG02xL2SO0PzVHVY3k/edit?ts=6016b0fb#

筆誤的部分修正了,目前最新版本是 Draft 15

@PichuChen PichuChen merged commit 235a8a6 into Ptt-official-app:development Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[主線] [PTT] 實作顯示發文限制 delivery/http
4 participants