Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

實作 #route board treasures test #134

Merged
merged 12 commits into from
Mar 13, 2021
Merged

實作 #route board treasures test #134

merged 12 commits into from
Mar 13, 2021

Conversation

eternalriverco
Copy link
Contributor

👏 解決掉的 issue / Resolved Issues

⛏ 變更內容 / Details of Changes

  • Implement MockUsecase.GetBoardTreasures
  • Added TestFetchBoardTreasures

@y2468101216
Copy link
Collaborator

LGTM

PichuChen
PichuChen approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@PichuChen PichuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PichuChen PichuChen merged commit b7daf4a into Ptt-official-app:development_enable_lint Mar 13, 2021
@eternalriverco eternalriverco deleted the test/#73-#route_board_treasures_test branch April 29, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PichuChen PichuChen PichuChen approved these changes

@y2468101216 y2468101216 y2468101216 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eternalriverco @y2468101216 @PichuChen @RicoToothless