實作顯示看板資訊細部資訊 #138
Merged
實作顯示看板資訊細部資訊 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
請 rebase |
Codecov Report
@@ Coverage Diff @@
## development #138 +/- ##
===============================================
- Coverage 38.88% 36.39% -2.49%
===============================================
Files 22 22
Lines 859 915 +56
===============================================
- Hits 334 333 -1
- Misses 475 530 +55
- Partials 50 52 +2
Continue to review full report at Codecov.
|
|
再麻煩幫忙review～ |
gogog22510
reviewed
Mar 21, 2021
| } | ||
|
|
||
| func marshalBoardHeader(b bbs.BoardRecord, l *usecase.BoardPostLimitation) map[string]interface{} { | ||
| func marshalBoardHeaderInfo(b bbs.BoardRecord, l *usecase.BoardPostLimitation) map[string]interface{} { |
There was a problem hiding this comment.
可以改成marshalBoardHeaderWithInfo或marshalBoardHeaderAndInfo增進可讀性。marshalBoardHeaderInfo乍看之下很像只有加入info本身
|
希望可以補上 getBoardSettings 測試 |
已補上～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決掉的 issue / Resolved Issues
📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes