Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加route_users 相關註解 #142

Conversation

y2468101216
Copy link
Collaborator

👏 解決掉的 issue / Resolved Issues

⛏ 變更內容 / Details of Changes

增加註解

@y2468101216 y2468101216 changed the title 增加註解並改為0.3版本 增加route_users 相關註解 Mar 16, 2021
@codecov-io
Copy link

Codecov Report

Merging #142 (6e53be4) into development (6239761) will increase coverage by 2.81%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #142      +/-   ##
===============================================
+ Coverage        36.06%   38.88%   +2.81%     
===============================================
  Files               21       22       +1     
  Lines              804      859      +55     
===============================================
+ Hits               290      334      +44     
- Misses             467      475       +8     
- Partials            47       50       +3     
Impacted Files Coverage Δ
internal/delivery/http/route_users.go 56.96% <ø> (ø)
internal/usecase/article.go 40.00% <0.00%> (-10.00%) ⬇️
internal/usecase/token.go 0.00% <0.00%> (ø)
internal/usecase/usecase.go 100.00% <0.00%> (ø)
internal/repository/board.go 0.00% <0.00%> (ø)
internal/delivery/http/http.go 50.00% <0.00%> (ø)
internal/delivery/http/route_append_comment.go 65.00% <0.00%> (ø)
internal/delivery/http/route.go 60.74% <0.00%> (+10.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6239761...6e53be4. Read the comment docs.

@y2468101216
Copy link
Collaborator Author

根據討論修改了

@y2468101216 y2468101216 force-pushed the test/#110-add_route_users_comments branch from 6e53be4 to bfc3abd Compare March 22, 2021 01:31
Copy link
Member

@PichuChen PichuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PichuChen PichuChen merged commit 1015d4e into Ptt-official-app:development Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[主線] [PTT] 增加 route_users.go , route_users_test.go , route_users_mock_test.go 的註解
3 participants