Implement http for user information and enhance test case #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync Forked Repo
Codecov Report
@@ Coverage Diff @@
## development #159 +/- ##
===============================================
- Coverage 39.93% 38.60% -1.34%
===============================================
Files 22 22
Lines 969 1005 +36
===============================================
+ Hits 387 388 +1
- Misses 526 561 +35
Partials 56 56
Continue to review full report at Codecov.
|
gogog22510
force-pushed
the
feature/100-user_information_http
branch
3 times, most recently
from
f98d4ba
to
3d9d697
Compare
PichuChen
reviewed
Apr 2, 2021
PichuChen
reviewed
Apr 2, 2021
PichuChen
requested changes
Apr 2, 2021
gogog22510
force-pushed
the
feature/100-user_information_http
branch
2 times, most recently
from
c128196
to
8086129
Compare
|
@gogog22510 好像有conflicts 要處理 |
gogog22510
force-pushed
the
feature/100-user_information_http
branch
from
8086129
to
e88fe88
Compare
原本的功能已經有實作了，我照著ISSUE上所描述的，做了修改test case以及logging error的動作 |
PichuChen
reviewed
Apr 9, 2021
|
我也看到change 0, 讓我研究看看.
!=無法比對map, 但deepequal可以
…On Fri, Apr 9, 2021, 12:15 PM Pichu Chen ***@***.***> wrote:
***@***.**** commented on this pull request.
我現在看到他的 Files changed = 0 ，是我這邊有問題嗎？
[image: 截圖 2021-04-10 上午12 14 17]
<https://user-images.githubusercontent.com/600238/114209862-b1f71600-9991-11eb-843b-dfd2b408d304.png>
------------------------------
In internal/delivery/http/route_users_test.go
<#159 (comment)>
:
> @@ -39,9 +57,9 @@ func TestGetUserInformation(t *testing.T) {
t.Logf("got response %v", rr.Body.String())
responsedData := responsedMap["data"].(map[string]interface{})
- if responsedData["user_id"] != userID {
- t.Errorf("handler returned unexpected body, user_id not match: got %v want userId %v",
- rr.Body.String(), userID)
+ if !reflect.DeepEqual(responsedData, expectedData) {
他這個可以用原本 != 而不是用 DeepEqual 嗎？
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#159 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4FGLQMMCNFB7PZOZRUQHTTH4R2LANCNFSM42IHPP6Q>
.
|
|
但是在寫測試上面，應該是直接把map用key比較會比較確定發生了什麼事？ |
gogog22510
force-pushed
the
feature/100-user_information_http
branch
from
9468f86
to
499f837
Compare
|
改成比對key了 |
PichuChen
requested changes
Apr 12, 2021
PichuChen
requested changes
Apr 13, 2021
gogog22510
force-pushed
the
feature/100-user_information_http
branch
from
499f837
to
eb085cc
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決掉的 issue / Resolved Issues
📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes