Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#166 取得儲存草稿 - delivery/http #170

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Feature/#166 取得儲存草稿 - delivery/http #170

merged 3 commits into from
Apr 16, 2021

Conversation

nickyanggg
Copy link
Collaborator

📝 相關的 issue / Related Issues

⛏ 變更內容 / Details of Changes

  • 修改 route.go 中的 parseUserPath
  • 修改 route_users_test.go 中的 TestParseUserPath
  • 在 route_users.go 中新增 getUserDrafts
  • 在 route_users_test.go 中新增 TestGetUserDrafts

@codecov-io
Copy link

codecov-io commented Apr 10, 2021

Codecov Report

Merging #170 (76f5448) into development (17e0da1) will increase coverage by 0.75%.
The diff coverage is 71.87%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #170      +/-   ##
===============================================
+ Coverage        40.20%   40.95%   +0.75%     
===============================================
  Files               22       22              
  Lines             1000     1028      +28     
===============================================
+ Hits               402      421      +19     
- Misses             539      545       +6     
- Partials            59       62       +3     
Impacted Files Coverage Δ
internal/usecase/usecase.go 100.00% <ø> (ø)
internal/usecase/user.go 6.86% <0.00%> (-0.07%) ⬇️
internal/delivery/http/route_users.go 55.62% <70.83%> (+2.34%) ⬆️
internal/delivery/http/route.go 62.28% <85.71%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17e0da1...76f5448. Read the comment docs.

@y2468101216
Copy link
Collaborator

請先解衝突歐

Copy link
Contributor

@SivWatt SivWatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickyanggg
Copy link
Collaborator Author

再麻煩幫忙 review ~

@PichuChen
Copy link
Member

LGTM

@PichuChen PichuChen merged commit fdcc4ca into Ptt-official-app:development Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants