Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#166 儲存、刪除草稿 - delivery/http #185

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Feature/#166 儲存、刪除草稿 - delivery/http #185

merged 2 commits into from
Apr 19, 2021

Conversation

nickyanggg
Copy link
Collaborator

@nickyanggg nickyanggg commented Apr 17, 2021

👏 解決掉的 issue / Resolved Issues

⛏ 變更內容 / Details of Changes

  • 在 route_users.go 中新增 postUsers 、postUserDrafts、updateUserDraft、deleteUserDraft
  • 在 route_users_test.go 中新增 TestUpdateUserDraft、TestDeleteUserDraft
  • 在 usecase/token.go 中新增 PermissionUpdateDraft、PermissionDeleteDraft

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #185 (f262051) into development (fdcc4ca) will increase coverage by 0.06%.
The diff coverage is 42.10%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #185      +/-   ##
===============================================
+ Coverage        41.69%   41.76%   +0.06%     
===============================================
  Files               23       23              
  Lines             1120     1214      +94     
===============================================
+ Hits               467      507      +40     
- Misses             584      630      +46     
- Partials            69       77       +8     
Impacted Files Coverage Δ
internal/usecase/token.go 0.00% <0.00%> (ø)
internal/usecase/usecase.go 100.00% <ø> (ø)
internal/usecase/user.go 8.41% <0.00%> (-0.17%) ⬇️
internal/delivery/http/route_users.go 51.20% <42.69%> (-4.42%) ⬇️
internal/delivery/http/route.go 63.86% <100.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdcc4ca...f262051. Read the comment docs.

Copy link
Member

@PichuChen PichuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y2468101216
Copy link
Collaborator

LGTM

@PichuChen PichuChen merged commit 9d6b2c4 into Ptt-official-app:development Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[主線] [PTT] 實作儲存草稿 - delivery/http
4 participants