Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forwardArticleToEmail #189

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

wagaru
Copy link
Collaborator

@wagaru wagaru commented Apr 22, 2021

👏 解決掉的 issue / Resolved Issues

📝 相關的 issue / Related Issues

⛏ 變更內容 / Details of Changes

  • 在 config_default.toml 新增 mailDriver 設定,預設為 smtp
  • 在 usecase.NewUsecase 會依據 config.MailDriver 設定 mail
  • 在 usecase 新增 updateMail 替換不同的 mail
  • 新增 mail.go 定義 Mail interface

@y2468101216
Copy link
Collaborator

請先把 ci 報錯修好

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #189 (bab8f7f) into development (2170aae) will increase coverage by 0.21%.
The diff coverage is 54.54%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #189      +/-   ##
===============================================
+ Coverage        41.74%   41.95%   +0.21%     
===============================================
  Files               23       24       +1     
  Lines             1217     1237      +20     
===============================================
+ Hits               508      519      +11     
- Misses             632      637       +5     
- Partials            77       81       +4     
Impacted Files Coverage Δ
internal/usecase/token.go 0.00% <0.00%> (ø)
internal/config/config.go 77.27% <25.00%> (-5.23%) ⬇️
internal/usecase/article.go 47.36% <53.84%> (+18.79%) ⬆️
internal/delivery/http/route_forward_article.go 70.17% <100.00%> (ø)
internal/usecase/mail.go 100.00% <100.00%> (ø)
internal/usecase/usecase.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2170aae...bab8f7f. Read the comment docs.

@y2468101216
Copy link
Collaborator

LGTM

@PichuChen PichuChen merged commit c85f848 into Ptt-official-app:development Apr 23, 2021
@PichuChen
Copy link
Member

LGTM, 接下來還需要另外實作 Mail Provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[主線] [PTT] 實作轉錄信箱 usecase module
4 participants