Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get user info usecase #190

Conversation

SivWatt
Copy link
Contributor

@SivWatt SivWatt commented Apr 22, 2021

👏 解決掉的 issue / Resolved Issues

📝 相關的 issue / Related Issues

⛏ 變更內容 / Details of Changes

  • usecase
    • 修改 GetUserInformation()strconv.FormatInt() 取代 fmt.Sprintf() 以改善效率
    • 新增 UserInformation test case
      • 測試傳入 not exist user 回傳 error
      • 測試傳入正確 user ID 回傳資料

@SivWatt SivWatt force-pushed the feature/165-user_information_usecase branch from ce6e92e to bf32e4f Compare April 25, 2021 09:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2021

Codecov Report

Merging #190 (bf32e4f) into development (c85f848) will increase coverage by 2.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #190      +/-   ##
===============================================
+ Coverage        41.95%   44.05%   +2.10%     
===============================================
  Files               24       24              
  Lines             1237     1237              
===============================================
+ Hits               519      545      +26     
+ Misses             637      611      -26     
  Partials            81       81              
Impacted Files Coverage Δ
internal/usecase/user.go 32.71% <100.00%> (+24.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85f848...bf32e4f. Read the comment docs.

@PichuChen
Copy link
Member

LGTM

@y2468101216
Copy link
Collaborator

LGTM

@PichuChen PichuChen merged commit 0dc9641 into Ptt-official-app:development Apr 27, 2021
@SivWatt SivWatt deleted the feature/165-user_information_usecase branch April 29, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[主線] [PTT] 實作個人看板的使用者資訊usecase
4 participants