Feature/#168 儲存草稿 - usecase #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #192 +/- ##
===============================================
+ Coverage 41.95% 45.55% +3.60%
===============================================
Files 24 25 +1
Lines 1237 1306 +69
===============================================
+ Hits 519 595 +76
+ Misses 637 624 -13
- Partials 81 87 +6
Continue to review full report at Codecov.
|
SivWatt
reviewed
Apr 25, 2021
| t.Errorf("returned unexpected value: got %v want value %v", | ||
| actualValue, expectedValue) | ||
| } | ||
| } |
There was a problem hiding this comment.
DeleteUserDraft 應該還是可以寫個test
測 return nil and error 兩個case
PichuChen
reviewed
Apr 25, 2021
internal/usecase/user.go
Outdated
| // TODO: https://github.com/Ptt-official-app/Ptt-backend/issues/168 | ||
| return []byte{}, nil | ||
| if !isValidDraftID([]byte(draftID)) { | ||
| return []byte{}, fmt.Errorf("invalid draft ID: %s", draftID) |
There was a problem hiding this comment.
要確認一下，有error的時候慣例上會回傳 nil 還是 []byte{} ?
|
再麻煩幫忙 review，感謝 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決掉的 issue / Resolved Issues
⛏ 變更內容 / Details of Changes