Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

推文repo更新 #202

Conversation

titaneric
Copy link
Contributor

👏 解決掉的 issue / Resolved Issues

⛏ 變更內容 / Details of Changes

  • AppendComment統一回傳PushRecord interface,這需要在go-bbs更新
  • 改寫AppendComment response body in delivery,使其與文件一致
  • 測試AppendComment repo mocked method

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #202 (0faf502) into development (0dc9641) will increase coverage by 0.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #202      +/-   ##
===============================================
+ Coverage        45.20%   45.91%   +0.70%     
===============================================
  Files               25       25              
  Lines             1294     1309      +15     
===============================================
+ Hits               585      601      +16     
+ Misses             623      622       -1     
  Partials            86       86              
Impacted Files Coverage Δ
internal/repository/article.go 0.00% <ø> (ø)
internal/repository/repository.go 0.00% <ø> (ø)
internal/usecase/usecase.go 100.00% <ø> (ø)
internal/delivery/http/route_append_comment.go 74.54% <100.00%> (+8.69%) ⬆️
internal/usecase/article.go 52.38% <100.00%> (+7.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc9641...0faf502. Read the comment docs.

Copy link
Member

@PichuChen PichuChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickyanggg nickyanggg self-requested a review May 1, 2021 03:01
Copy link
Collaborator

@nickyanggg nickyanggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SivWatt SivWatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PichuChen PichuChen merged commit 0613269 into Ptt-official-app:development May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[主線] [PTT] 實作文章推文 repository
5 participants