add post token test and add .vscode gitignore #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkfsn
reviewed
Feb 5, 2021
|
Could you please rebase onto the latest |
ok，I will rebase on Monday. |
y2468101216
force-pushed
the
route_test
branch
from
973bc4c
to
cb8efc9
Compare
Codecov Report
@@ Coverage Diff @@
## development #37 +/- ##
==============================================
+ Coverage 6.23% 9.69% +3.45%
==============================================
Files 19 20 +1
Lines 577 588 +11
==============================================
+ Hits 36 57 +21
+ Misses 538 526 -12
- Partials 3 5 +2
Continue to review full report at Codecov.
|
reabse done. if I need to squash, please tell me |
y2468101216
force-pushed
the
route_test
branch
from
fcfb82e
to
bbf5d1d
Compare
PichuChen
requested changes
Feb 9, 2021
Feat/search articles
Some fields are missing in the current implementation since go-bbs does not export those methods yet. Use a mock to fill the fields
…nfomation Implement issue Ptt-official-app#58 [主線] [PTT] 實作個人看板的使用者資訊 (repository)
y2468101216
force-pushed
the
route_test
branch
from
bd816b3
to
d9f5bd9
Compare
y2468101216
force-pushed
the
route_test
branch
from
d06f16c
to
76cc979
Compare
y2468101216
changed the base branch from
development
to
development_enable_lint
PichuChen
approved these changes
Feb 17, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes
完成了 route_token_test.go 的測試部分，使用 mock