Implement #53 Get popular board list #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: wagaru <wagaru@hotmail.com>
Co-authored-by: wagaru <wagaru@hotmail.com>
PHChenGit
approved these changes
Feb 13, 2021
|
LGTM |
PichuChen
requested changes
Feb 13, 2021
| @@ -86,6 +86,10 @@ func (usecase *MockUsecase) GetBoards(ctx context.Context, userID string) []bbs. | |||
| panic("Not implemented") | |||
| } | |||
|
|
|||
| func (usecase *MockUsecase) GetPopularBoards(ctx context.Context) []bbs.BoardRecord { | |||
| panic("Not implemented") | |||
There was a problem hiding this comment.
這邊能不能不要用 panic, 而是return error?
internal/usecase/usecase.go
Outdated
| @@ -24,6 +24,8 @@ type Usecase interface { | |||
| GetBoardByID(ctx context.Context, boardID string) (bbs.BoardRecord, error) | |||
| // GetBoards returns all board records | |||
| GetBoards(ctx context.Context, userID string) []bbs.BoardRecord | |||
| // GetPopularBoards returns top 100 popular board records | |||
| GetPopularBoards(ctx context.Context) []bbs.BoardRecord | |||
|
已修改完畢，那因為目前 GetPopularBoards 太過簡單，所以目前 error 值都回傳 nil，之後如果排序的部分可以實作或是 usecase.repo.GetBoards 也有回傳 error 值的話再更改。 |
Some fields are missing in the current implementation since go-bbs does not export those methods yet. Use a mock to fill the fields
Implement issue #58 [主線] [PTT] 實作個人看板的使用者資訊 (repository)
add route classes test
添加 openapi 支援
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes