實作 #53 Get popular board list #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PichuChen
reviewed
Feb 19, 2021
| boards, err := delivery.usecase.GetPopularBoards(context.Background()) | ||
| if err != nil { | ||
| // TODO: record error | ||
| delivery.logger.Warningf("find popular board failed: %v", err) |
There was a problem hiding this comment.
因為使用者沒辦法順利進行某一項功能了，也許這邊應該是使用 Errorf 會更好？
Julian-Chu
suggested changes
Feb 19, 2021
| if err != nil { | ||
| // TODO: record error | ||
| delivery.logger.Errorf("find popular board failed: %v", err) | ||
| w.WriteHeader(http.StatusInternalServerError) |
There was a problem hiding this comment.
建議把w.WriteHeader 放在w.Write上一行， 閱讀起來的連貫性比較好
| t.Logf("got response %v", rr.Body.String()) | ||
| responseData := responseMap["data"] | ||
| popularBoards := responseData.(map[string]interface{})["items"].([]interface{}) | ||
| for i := range popularBoards[1:] { |
There was a problem hiding this comment.
可以寫得更直觀一點，另外atoi失敗或不按順序排列就直接t.Fatalf，不用再比較下去了
Suggested change
| for i := range popularBoards[1:] { | |
| var prevNum int | |
| for i := range popularBoards{ | |
| curr := popularBoards[i].(map[string]interface{})["number_of_user"] | |
| currNum, err := strconv.Atoi(curr.(string)) | |
| if err != nil { | |
| t.Fatalf("handler returned unexpected body, invalid number_of_user: got %v", | |
| currNum) | |
| } | |
| if i > 0 && prevNum < currNum { | |
| t.Fatalf("handler returned unexpected body, invalid order: got %v before %v", | |
| prevNum, currNum) | |
| } | |
| prevNum = currNum | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes
因為之前再寫的時候 ptt-backend 是蠻舊版本的，所以就重新 merge、增加了簡單的測試並重發 pr。