修正 windows build fail 問題 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PichuChen
reviewed
Mar 10, 2021
cache/systemvshm_windows.go
Outdated
| @@ -22,3 +26,7 @@ func shmdt(shmaddr uintptr) (int, error) { | |||
| func shmctl(shmid int, cmd int, buf *ShmidDs) (int, error) { | |||
| return 0, fmt.Errorf("windows do not implement shmctl") | |||
| } | |||
|
|
|||
| func ShmSegsz(shmid int, cmd int, buf *ShmidDs) (int, error) { | |||
PichuChen
reviewed
Mar 10, 2021
cache/mmap_windows.go
Outdated
| ) | ||
|
|
||
| func openMmap(fd int, size int) ([]byte, error) { | ||
| return nil, fmt.Errorf("windows do not implement shmget") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("windows do not implement shmget") | |
| return nil, fmt.Errorf("TODO: implement open mmap") |
PichuChen
reviewed
Mar 10, 2021
cache/mmap_windows.go
Outdated
| } | ||
|
|
||
| func closeMmap(buf []byte) error { | ||
| return fmt.Errorf("windows do not implement shmget") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("windows do not implement shmget") | |
| return fmt.Errorf("TODO: implement close mmap") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決掉的 issue / Resolved Issues
📝 相關的 issue / Related Issues
無
⛏ 變更內容 / Details of Changes
增加了 windows build 的支援。