Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization for BoardHeader #70

Merged

Conversation

titaneric
Copy link
Collaborator

👏 解決掉的 issue / Resolved Issues

⛏ 變更內容 / Details of Changes

  • 補足BoardHeader剩餘欄位
  • 新增對應測試,但因原本的測試資料中在BrdName及title這兩個field中有塞其他資料(NewBoardHeaderWithByte才要用split取\x00之前的),所以沒辦法全測,改測前兩個。

@PichuChen
Copy link
Member

LGTM

@PichuChen PichuChen merged commit cdcd497 into Ptt-official-app:development Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[主線] [PTT] 補足Board struct MarshalBinary method
2 participants