Skip to content

Commit

Permalink
PulsePoint Adapter: crid fix (prebid#3466)
Browse files Browse the repository at this point in the history
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* Minor fix

* Adding mandatory parameters to Bid

* PulsePoint crid fix
  • Loading branch information
anand-venkatraman authored and jaiminpanchal27 committed Jan 28, 2019
1 parent af9ec3f commit e3c652f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions modules/pulsepointBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ function bidResponseAvailable(bidRequest, bidResponse) {
const bid = {
requestId: id,
cpm: idToBidMap[id].price,
creative_id: id,
creativeId: id,
creative_id: idToBidMap[id].crid,
creativeId: idToBidMap[id].crid,
adId: id,
ttl: DEFAULT_BID_TTL,
netRevenue: DEFAULT_NET_REVENUE,
Expand Down
7 changes: 4 additions & 3 deletions test/spec/modules/pulsepointBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ describe('PulsePoint Adapter Tests', function () {
bid: [{
impid: ortbRequest.imp[0].id,
price: 1.25,
adm: 'This is an Ad'
adm: 'This is an Ad',
crid: 'Creative#123'
}]
}]
};
Expand All @@ -97,8 +98,8 @@ describe('PulsePoint Adapter Tests', function () {
expect(bid.width).to.equal(300);
expect(bid.height).to.equal(250);
expect(bid.adId).to.equal('bid12345');
expect(bid.creative_id).to.equal('bid12345');
expect(bid.creativeId).to.equal('bid12345');
expect(bid.creative_id).to.equal('Creative#123');
expect(bid.creativeId).to.equal('Creative#123');
expect(bid.netRevenue).to.equal(true);
expect(bid.currency).to.equal('USD');
expect(bid.ttl).to.equal(20);
Expand Down

0 comments on commit e3c652f

Please sign in to comment.